Hi, 2010/12/13 Felipe Balbi <balbi@xxxxxx>: > Hi, > > On Mon, Dec 13, 2010 at 01:01:48AM +0800, tom.leiming@xxxxxxxxx wrote: >> >> From: Ming Lei <tom.leiming@xxxxxxxxx> >> >> Each hw controller may have different fifo configuraion, >> so passing fifo_mode from hw glue is very reasonable. > > there's already a way for boards to pass in fifo_mode via platform_data. You mean musb_hdrc_platform_data? Seems it doesn't have fifo mode information, also musb core only uses the fifo mode from static variable of 'fifo_mode' currently. IMHO, introducing fifo_mode in glue layer is more doable than in board data, since all boards shipped with same hw musb controller(omap2430/davinci/tusb/...) should use the same default fifo mode. Any suggestions? -- Lei Ming -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html