On Wed, Dec 15, 2010 at 02:46:52PM +0800, Xu, Andiry wrote: > > -----Original Message----- > > From: Sarah Sharp [mailto:sarah.a.sharp@xxxxxxxxxxxxxxx] > > Andiry, why were you only resuming the roothub when something was > > connected to the port? If I remove the first conditional, then the > > system works as expected and I see a new connect after the 'remove' > > sysfs file is written. > > > > Ah... I've reproduced this issue and verify that remove the first > conditional resolves it. In my original design I assume that when a new > device connects to a suspended hcd, it should be resumed; disconnect a > device from a suspended hcd without resume it seems harmless. Apparently > I'm wrong and ignore the CSC bit clear... As Alan says, any port status > change should resume the root hub. Thanks for catching this. I'm OK with > the RFC patch. Ok, I just wanted to make sure you didn't put that check in for, say, a buggy host that gave spurious port status changes. I'll send this off to Greg, although I might wait until you get the MSI/MSI-X synchronization patch done, so I can send both fixes at once. Sarah Sharp -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
