Re: [PATCH v2 01/25] usb: otg: add unified otg_notify function for usb_otg_event notification

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Dec 13, 2010 at 11:58:17AM -0500, Alan Stern wrote:
On Mon, 13 Dec 2010, Felipe Balbi wrote:

>Did you check if those things depending on blocking notifiers can be
>changed?
>
>How about this, you introduce atomic notifiers without removing the
>blocking once. The blocking notifiers you mark as deprecated. This way
>you at least start discussion on the matter?

naa, that's two notifiers for the same thing. Just convert everybody to
atomic notifiers.

The existing usb notifiers cannot be changed to atomic.  They get used
by notifier routines that have to be able to sleep.

But of course that doesn't prevent anyone from creating a new atomic
notifier chain for use by OTG.

There's already OTG notifiers and I was talking about that one:

struct otg_transceiver {
	struct device		*dev;
	const char		*label;
	unsigned int		 flags;

	u8			default_a;
	enum usb_otg_state	state;

	struct usb_bus		*host;
	struct usb_gadget	*gadget;

	struct otg_io_access_ops	*io_ops;
	void __iomem			*io_priv;

	/* for notification of usb_xceiv_events */
	struct blocking_notifier_head	notifier;
	[...]

--
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux