Re: [PATCH v2 01/25] usb: otg: add unified otg_notify function for usb_otg_event notification

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Dec 13, 2010 at 02:51:44PM +0200, Heikki Krogerus wrote:
Hi,

On Mon, Dec 13, 2010 at 05:47:48PM +0800, ext Wu, Hao wrote:
My advice is to use the existing notifiers. If they are not quite what
you want, first try to make them work for you. If it's a problem that
they are blocking and not atomic, then make them atomic. Don't try to
first bring something totally new.

Actually I did not want to break anything here. A lot of
things(usbdev/mon/usbfs/...) use the blocking one, i prefer keep them not
touched. so I have to use something different.

Did you check if those things depending on blocking notifiers can be
changed?

How about this, you introduce atomic notifiers without removing the
blocking once. The blocking notifiers you mark as deprecated. This way
you at least start discussion on the matter?

naa, that's two notifiers for the same thing. Just convert everybody to
atomic notifiers.

--
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux