On Fri, Dec 03, 2010 at 03:08:27PM +0300, Sergei Shtylyov wrote:
Why not just copy pdev->dev->dma_mask and pdev->dev->coherenet_dma_mask?
+ platform_set_drvdata(pdev, musb);
+
+ ret = platform_device_add_resources(musb, pdev->resource,
+ pdev->num_resources);
But not all DaVinci's resources belong to MUSB per se -- the part
of the memory range is occupied by CPPI engine, and the possible
second IRQ belongs to CPPI too. MUSB resource itself starts at offset
0x400.
You can provide a patch fixing those.
+static int __exit davinci_remove(struct platform_device *pdev)
+{
+ struct platform_device *musb = platform_get_drvdata(pdev);
+
+ platform_device_put(musb);
+ platform_device_del(musb);
Same question here. Here we do need platform_device_del() though
(but it should come first)...
true, will fix.
+MODULE_DESCRIPTION("OMAP2PLUS MUSB Glue Layer");
You meant to type DaVinci here?
copy and paste.
+MODULE_AUTHOR("Felipe Balbi <balbi@xxxxxx>");
Er, are you really the author of this file?
copy and paste erros, and I forgot to fix.
--
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
