On Fri, Dec 03, 2010 at 03:08:27PM +0300, Sergei Shtylyov wrote:
Shouldn't the call to platform_device_del() precede the call to platform_device_put()? At least that's how drivers/base/platform.c does its error cleanup. And I doubt that we need a call to platform_device_del() at all since it's coupled to platform_device_add()...
good point, will fix.
+static int __exit davinci_remove(struct platform_device *pdev) +{ + struct platform_device *musb = platform_get_drvdata(pdev); + + platform_device_put(musb); + platform_device_del(musb);Same question here. Here we do need platform_device_del() though (but it should come first)...+MODULE_DESCRIPTION("OMAP2PLUS MUSB Glue Layer");You meant to type DaVinci here?+MODULE_AUTHOR("Felipe Balbi <balbi@xxxxxx>");Er, are you really the author of this file?
who knows who's the original author. There needs to be someone as a contact for those and I used the name of the person who added the file to mainline originally which was myself in this case. -- balbi -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
