On Tue, Oct 19, 2010 at 12:01 PM, Felipe Balbi <balbi@xxxxxx> wrote: > On Tue, Oct 19, 2010 at 03:34:55AM -0500, Felipe Contreras wrote: >>> >>> It was fine as it was before. NAK >> >> It's not fine. You can build with CONFIG_USB_G_NOKIA=y, and it doesn't >> work. Definitely some dependency is missing. > > if phonet is not set it should not build. If phonet is set to module and > g_nokia to built-in, then it's your mistake. I'm not talking about phonet, I replied to your comment regarding USB_GADGET_MUSB_HDRC. For me USB_GADGET_MUSB_HDRC=n USB_G_NOKIA=y doesn't work, but the Kconfig allows it. >> How do you handle USB_MUSB_HDRC=y and NOP_USB_XCEIV=n and TWL4030_USB=n? >> >> depends on (NOP_USB_XCEIV || TWL4030_USB) ? > > you're selecting, not depending on this patch. What I mean is that you > will enable a useless driver on some boards if you "select TWL4030_USB > if ARCH_OMAP3" Ok, I'll make it: depends on (NOP_USB_XCEIV || TWL4030_USB) BTW, if you want to try this: ./scripts/kconfig/conf --defconfig=usb_defconfig arch/arm/Kconfig usb_defconfig: CONFIG_ARCH_OMAP=y CONFIG_EXPERIMENTAL=y CONFIG_NET=y CONFIG_PHONET=y CONFIG_USB=y CONFIG_USB_GADGET=y CONFIG_USB_MUSB_OTG=y CONFIG_USB_MUSB_HDRC=y CONFIG_USB_G_NOKIA=y # TODO USB_MUSB_OTG should select this CONFIG_USB_GADGET_MUSB_HDRC=y I expect TWL4030_USB and USB_OTG to be automatically selected. -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
