On Tue, Oct 19, 2010 at 11:18 AM, Felipe Balbi <balbi@xxxxxx> wrote: > On Tue, Oct 19, 2010 at 03:04:26AM -0500, Felipe Contreras wrote: >> >> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig >> index db51ea1..523df52 100644 >> --- a/drivers/mfd/Kconfig >> +++ b/drivers/mfd/Kconfig >> @@ -156,6 +156,8 @@ config MENELAUS >> config TWL4030_CORE >> Â Â Â Âbool "Texas Instruments TWL4030/TWL5030/TWL6030/TPS659x0 Support" >> Â Â Â Âdepends on I2C=y && GENERIC_HARDIRQS >> + Â Â Â depends on ARCH_OMAP3 || ARCH_OMAP4 > > It's just an i2c chip, not depending on OMAP will allow us for a much > needed compile test on linux-next with different architectures. Ok. >> @@ -842,7 +840,8 @@ config USB_CDC_COMPOSITE >> >> config USB_G_NOKIA >> Â Â Â Âtristate "Nokia composite gadget" >> - Â Â Â depends on PHONET >> + Â Â Â depends on PHONET && MACH_NOKIA_RX51 > > no. g_nokia only depends on PHONET, if someone else wants to use on > another board, it's fine by me. Otherwise we will have to keep on adding > more and more boards. Ok. >> + Â Â Â depends on USB_GADGET_MUSB_HDRC > > this gadget also works on controllers other than musb. As long as they > support enough endpoints and alternate settings, it should just work. > > It was fine as it was before. NAK It's not fine. You can build with CONFIG_USB_G_NOKIA=y, and it doesn't work. Definitely some dependency is missing. >> diff --git a/drivers/usb/musb/Kconfig b/drivers/usb/musb/Kconfig >> index 20895c4..5484258 100644 >> --- a/drivers/usb/musb/Kconfig >> +++ b/drivers/usb/musb/Kconfig >> @@ -12,7 +12,7 @@ config USB_MUSB_HDRC >> Â Â Â Âdepends on (USB || USB_GADGET) >> Â Â Â Âdepends on (ARM || (BF54x && !BF544) || (BF52x && !BF522 && >> !BF523)) >> Â Â Â Âselect NOP_USB_XCEIV if (ARCH_DAVINCI || MACH_OMAP3EVM || BLACKFIN) >> - Â Â Â select TWL4030_USB if MACH_OMAP_3430SDP >> + Â Â Â select TWL4030_USB if ARCH_OMAP3 > > we have omap3-based boards which don't use twl4030-usb, they use > nop-usb-xceiv. How do you want to handle that ?? NAK How do you handle USB_MUSB_HDRC=y and NOP_USB_XCEIV=n and TWL4030_USB=n? depends on (NOP_USB_XCEIV || TWL4030_USB) ? -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
