RE: [PATCH 2/3 v2 RESEND] xHCI: change xhci_reset_device() to allocate new device

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> -----Original Message-----
> From: Sarah Sharp [mailto:sarah.a.sharp@xxxxxxxxxxxxxxx]
> Sent: Saturday, October 09, 2010 7:39 AM
> To: Xu, Andiry
> Cc: linux-usb@xxxxxxxxxxxxxxx; gregkh@xxxxxxx; Alan Stern; Su, Henry;
He,
> Alex
> Subject: Re: [PATCH 2/3 v2 RESEND] xHCI: change xhci_reset_device() to
> allocate new device
> 
> I've done some more testing, and Andiry's seven PM patches (mostly)
> work, when I apply the two extra patches that are attached.  The first
> patch fixes the control endpoint issue I described, and the second
patch
> fixes an issue with persistent USB 3.0 devices across suspend with a
> power loss and hibernate.
> 
> Alan, could you look over the second patch?  It fixes the issue I was
> seeing, but I'm not sure if there are further-reaching implications
for
> khubd when a USB 3.0 port is not disabled after a hub reset-resume.
> 
> Andiry, I've been testing suspend and hibernate support on my laptop
> with an NEC express card.  The card isn't powered across the suspend,
> and I'm testing with CONFIG_PM_RUNTIME=y and CONFIG_USB_SUSPEND=n.
> 
> Suspend and hibernate work fine with USB 2.0 devices under xHCI.
> Inactive USB 3.0 devices also seem to work after both suspend and
> hibernate.
> 
> However, I'm seeing an issue that is triggered by playing a movie on a
> USB 3.0 hard drive when I attempt to hibernate.  The first couple of
> times, my xserver or i915 driver seemed to act up (screen blank but
> mouse still there, or screen brightness turned completely down with no
> response to contrast buttons).
> 
> The third time the hibernate worked successfully, but when I
immediately
> tried to hibernate it again, the computer rebooted on resume.  The
> fourth time the PM subsystem seemed to get stuck in the "syncing
> filesystems" portion, and bulk endpoint transfers from the USB 3.0
> device kept streaming by.  The magic sysreq keys worked, and I was
able
> to umount the drive and reboot.  I haven't been able to get any useful
> dmesg output.
> 
> I'm not sure if my issues are caused by my graphics hardware/xserver,
> so could you try to reproduce this issue on your own systems?
> 

Hi Sarah,

I've tested on 2.6.36-rc7 with Buffalo USB3.0 HDD, playing a movie on it
and then use pm-hibernate to enter S4. I've try several times and the
movie resumes playing when the system wake up. It may take several
seconds for the USB3.0 HDD to be re-initialized, after that it will
resume working. The config is set with CONFIG_PM_RUNTIME=y and
CONFIG_USB_SUSPEND=n.

Does this issue occurs with suspend and CONFIG_USB_SUSPEND=y? Do the two
patches you attached help to resolve this issue? Is it the same issue
with you another mail mentioning call trace in xhci_endpoint_init()? I
will do more tests on my side and try to reproduce this issue.

Thanks,
Andiry

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux