On Mon, Oct 4, 2010 at 5:30 PM, Ming Lei <tom.leiming@xxxxxxxxx> wrote: > 2010/10/4 Felipe Balbi <balbi@xxxxxx>: >> Hi, >> >> On Fri, Oct 01, 2010 at 10:18:03PM -0500, Ming Lei wrote: >>> >>> No, we only configure the max hw fifo size for each hw endpoint during >>> setup endpoint, but the actual max packet size for one endpoint in >>> usb device is very possible less than max hw fifo size of each hw >>> endpoint, such as in fullspeed case. >>> >>> The actual max packet size is from endpoint descriptor and should >>> always be set to MUSB_RXMAXP/MUSB_TXMAXP register in >>> musb_gadget_enable function. >> >> but that's what we do, no ?? > > Yes, it is what the patch does, so need you to apply the patch below... > > [PATCH 2/2] USB: musb: gadget: fix MUSB_TXMAXP and MUSB_RXMAXP configuration. > > > thanks, > -- > Lei Ming > -- > To unsubscribe from this list: send the line "unsubscribe linux-usb" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at Âhttp://vger.kernel.org/majordomo-info.html > Hi, Ming In my test testusb will hang at case 4 with this patch. The testscript is like this: =============== #!/bin/bash sudo modprobe usbtest sudo mount -t usbfs none /proc/bus/usb gadget_bus=`lsusb | grep "Gadget Zero" | awk '{print $2}'` gadget_dev=`lsusb | grep "Gadget Zero" | awk '{print $4}' | awk -F: '{print $1}'` sudo ./testusb -D /proc/bus/usb/$gadget_bus/$gadget_dev -t14 -c 15000 -s 256 -v 1 for count in `seq 1 9`; do sudo ./testusb -D /proc/bus/usb/$gadget_bus/$gadget_dev -t$count sleep 1 done sudo rmmod usbtest ======================== result: ==============bob@adam-desktop:~/usb$ ./newtest.sh mount: none already mounted or /proc/bus/usb busy mount: according to mtab, none is already mounted on /proc/bus/usb unknown speed /proc/bus/usb/002/026 /proc/bus/usb/002/026 test 14, 3.849498 secs unknown speed /proc/bus/usb/002/026 /proc/bus/usb/002/026 test 1, 0.127008 secs unknown speed /proc/bus/usb/002/026 /proc/bus/usb/002/026 test 2, 0.126008 secs unknown speed /proc/bus/usb/002/026 /proc/bus/usb/002/026 test 3, 0.127255 secs unknown speed /proc/bus/usb/002/026 /proc/bus/usb/002/026 test 4, 0.131634 secs unknown speed /proc/bus/usb/002/026 "hang at here................ ============== -- Regards, --Bob -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
