Re: [PATCH 2/2] USB: musb: gadget: fix MUSB_TXMAXP and MUSB_RXMAXP configuration

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Fri, Oct 01, 2010 at 10:18:03PM -0500, Ming Lei wrote:
No, we only configure the max hw fifo size for each hw endpoint during
setup endpoint, but the actual max packet size for one endpoint in
usb device is very possible less than max hw fifo size of each hw
endpoint, such as in fullspeed case.

The actual max packet size is from endpoint descriptor and should
always be set to MUSB_RXMAXP/MUSB_TXMAXP register in
musb_gadget_enable function.

but that's what we do, no ??

The change is also wrong, which may degrade performance a lot
if musb_ep->packet_sz is less than hw_ep->max_packet_sz_tx or
hw_ep->max_packet_sz_rx.

well, it's not supposed to be applied anywhere, more like a debugging
patch ;-)

--
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux