--- On Thu, 9/2/10, Martin Fuzzey <mfuzzey@xxxxxxxxx> wrote: > > > >> > > >> > This mimics the behaviour of drivers such as > usbnet > > > > No need to single out usbnet by describing any > > of what it does. It's not the only driver which > > insists only that its buffers be valid, rather than > > trying (or happening) to align them. > > > I'm not implying that usbnet does anything wrong, > merely pointing out a real world case where the > problem that the new tests check for can occur. But the "problem" isn't in usbnet, it's in the HCD. You focussed on usbnet, not the problem site. Better would be to describe the the problem; as I've put it: buggy HCD, wrongly insisting on adding alignment restrictions to buffers. > > > I don't actually see a patch I could ACK or NAK; > > got URL? > > First message in this thread : > http://marc.info/?l=linux-usb&m=128318949614553 Have you verified that still works with for example EHCI, OHCI, and UHCI? It looked more or less OK to me, except for the weak test descriptions: they're just verifying that HCDs don't wrongly restrict the data buffers. Fix the test description to emphasize the right thing (HCD not usbnet) and I can see me acking the result. > > Regards, > > Martin -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
