--- On Wed, 9/1/10, Greg KH <greg@xxxxxxxxx> wrote: ] > +0200, Martin Fuzzey wrote: > > This patch adds two new tests: #17 and #18 which are similar to > > tests #1 and #2 except that instead of allocating the > data buffers > > with usb_alloc_coherent() and setting > URB_NO_TRANSFER_DMA_MAP > > they use kmalloc() plus a 0-3 byte offset and let the > core > > do the DMA mapping. Fair enough ... > > > > This mimics the behaviour of drivers such as usbnet No need to single out usbnet by describing any of what it does. It's not the only driver which insists only that its buffers be valid, rather than trying (or happening) to align them. > which add > > an offset to the transfer_buffer to align the IP > header and > > causes problems for HCDs that don't accept arbitary alignment for DMA buffers. i.e. buggy HCDs that try to add constraints to buffers beyond the trivial ones of usbcore. > > > > Signed-off-by: Martin Fuzzey <mfuzzey@xxxxxxxxx> > > I need an ack from David Brownell for this one I don't actually see a patch I could ACK or NAK; got URL? before I can > apply it. > > thanks, > > greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
