On Wed, Sep 01, 2010 at 02:10:17PM -0700, Greg KH wrote: > On Thu, Aug 12, 2010 at 05:43:46PM +0200, Michal Nazarewicz wrote: > > The iManufatcurer, iProduct and iSerialNumber composite module > > parameters were only used when the gadget driver registers > > strings for manufacturer, product and serial number. If the > > gadget never bothered to set corresponding fields in USB device > > descriptors those module parameters are ignored. > > > > This commit makes the parameters work even if the strings ID > > have not been assigned. It also changes the way IDs are > > overridden -- what IDs are overridden is now saved in > > usb_composite_dev structure -- which makes it unnecessary to > > modify the string tables the way previous code did. > > > > The commit also adds a iProduct and iManufatcurer fields to the > > usb_composite_device structure. If they are set, appropriate > > strings are reserved and added to device descriptor. This makes > > it unnecessary for gadget drivers to maintain code for setting > > those. If iProduct is not set it defaults to > > usb_composite_device::name; if iManufatcurer is not set > > a default "<system> <release> with <gadget-name>" is used. > > > > The last thing is that if needs_serial field of > > usb_composite_device is set and user failed to provided > > iSerialNumber parameter a warning is issued. > > > > Signed-off-by: Michal Nazarewicz <m.nazarewicz@xxxxxxxxxxx> > > Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx> > > This patch doesn't apply on the latest tree, care to respin it, and the > ones after it as well? Oops, my fault, nevermind, I got it fixed... thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
