Re: [PATCH] fix hwa-hc / hwa-rc binary module dependencies

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Christopher Friedt wrote:
> Christopher Friedt (1):
>   Corrected missing binary module dependency of hwa-hc on hwa-rc and
>     consistent probe failure of hwa-hc. The problem: hwa-rc did not
>     export any symbols, but hwa-hc depended on it. Hwa-hc gets its
>     uwb_rc through private driver data. If hwa-rc is not loaded prior
>     to hwa-hc, then that private driver data is NULL. The problem is
>     fixed manually by loading hwa-rc and then hwa-hc. However, due to
>     the missing binary module dependency (i.e. "Used by" field in
>     lsmod), one can rmove the hwa-rc module while the hwa-hc module is
>     loaded, leaving any pointers to the uwb_rc struct invalid. This
>     patch is obviously mainly for illustrative purposes, but it does
>     actually fix both of the aforementioned problems.

NAK.  There is a device dependency not a module dependency.

See my other email for a suggested solution.

In the short term, I'd suggest looking at some udev rules to get the
hwa-rc module loaded before the hwa-hc module.

David
-- 
David Vrabel, Senior Software Engineer, Drivers
CSR, Churchill House, Cambridge Business Park,  Tel: +44 (0)1223 692562
Cowley Road, Cambridge, CB4 0WZ                 http://www.csr.com/


Member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux