On Mon, 23 Aug 2010, Maulik Mankad wrote: > > All the mappings are done in map_urb_for_dma, except in the case where > > the buffer was set up for a coherent mapping. If you always call > > unmap_urb_for_dma then you won't have to worry about strange drivers or > > exceptional cases. Besides, it means adding less new code than your > > patch contains. > > > > Yes thats true. > > Calling unmap_urb_for_dma() will handle all cases and would be most effective. > > So is it okay to make it non-static and export it? > > Will such a patch be acceptable (since it is in core/hcd.c)? Yes, it's okay and acceptable. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html