Re: [RFC] [PATCH 3/7] usb: ehci-omap: omap: Add OMAP4 support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Thu, Aug 19, 2010 at 01:49:33AM +0200, ext Keshava Munegowda wrote:
@@ -298,7 +327,163 @@ static int omap_start_ehc(struct ehci_hc
	}

	if (cpu_is_omap44xx()) {
-		/* TODO */

driver should never make use of cpu_is_omap* calls neither machine_is_* for that matter. Driver shouldn't care about correct clock names either. You need to find a better to handle differences between omap3 and omap4.

--
balbi

DefectiveByDesign.org
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux