On Wed, 18 Aug 2010 07:14:37 -0700 (PDT) Michael Wileczka <mikewileczka@xxxxxxxxx> wrote: > From: Michael Wileczka <mikewileczka@xxxxxxxxx> > > The USB max packet size (always little-endian) was not being byte swapped on big-endian systems. > Created with 2.6.32.16 > Applicable since [USB: ftdi_sio: fix hi-speed device packet size calculation] approx 2.6.31 > > Signed-off-by: Michael Wileczka <mikewileczka@xxxxxxxxx> > --- > --- a/drivers/usb/serial/ftdi_sio.c > +++ b/drivers/usb/serial/ftdi_sio.c > @@ -1397,7 +1397,7 @@ static void ftdi_set_max_packet_size(str > } > > /* set max packet size based on descriptor */ > - priv->max_packet_size = ep_desc->wMaxPacketSize; > + priv->max_packet_size = le16_to_cpu(ep_desc->wMaxPacketSize); > > dev_info(&udev->dev, "Setting MaxPacketSize %d\n", priv->max_packet_size); > } So I guess nobody noticed this because the driver deosn't get used on big-endian machines a lot? What are the user-visible effects of this bug? -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
