On Thu, 12 Aug 2010 19:02:14 +0200, Greg KH <gregkh@xxxxxxx> wrote:
On Thu, Aug 12, 2010 at 02:08:10PM +0200, Michał Nazarewicz wrote:
On Wed, 11 Aug 2010 00:48:37 +0200, David Brownell <david-b@xxxxxxxxxxx> wrote:
>>- /* On a real device, serial[] would be
>>loaded from permanent
>>- * storage. We just
>>encode it from the driver version string. */
>
>I still want to see that get fixed. Just
>require a Real (managed) serial string, instead of
>consing up something non-unique.
>
>If you're going to create buggy serial numbers,
>make a point of issuing warnings ... better yet,
>don't do the buggy thing.
My patch:
USB: gadget: file_storage: serial parameter even if not test mode
included in today's next as:
commit 567064916e4fe32af81b89e473a1e4f40c64b27b
adds a warning.
And you sent a fix for this already, right?
Yep, you have it in your tree already.
--
Best regards, _ _
| Humble Liege of Serenely Enlightened Majesty of o' \,=./ `o
| Computer Science, Michał "mina86" Nazarewicz (o o)
+----[mina86*mina86.com]---[mina86*jabber.org]----ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html