Re: [PATCH 027/148] USB: Add a serial number parameter to g_file_storage module

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Aug 12, 2010 at 02:08:10PM +0200, Michał Nazarewicz wrote:
> On Wed, 11 Aug 2010 00:48:37 +0200, David Brownell <david-b@xxxxxxxxxxx> wrote:
> 
> >>-    /* On a real device, serial[] would be
> >>loaded from permanent
> >>-     * storage.  We just
> >>encode it from the driver version string. */
> >
> >I still want to see that get fixed.  Just
> >require a Real (managed) serial string, instead of
> >consing up something non-unique.
> >
> >If you're going to create buggy serial numbers,
> >make a point of issuing warnings ... better yet,
> >don't do the buggy thing.
> 
> My patch:
> 	USB: gadget: file_storage: serial parameter even if not test mode
> included in today's next as:
> 	commit 567064916e4fe32af81b89e473a1e4f40c64b27b
> adds a warning.

And you sent a fix for this already, right?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux