Re: [PATCH RESEND] USB HID: Add ID for eGalax Multitouch used in JooJoo tablet

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 13 Aug 2010, Chris Ball wrote:

>    > has this patch been really tested?
>    >
>    > I am almost certain that we need to have the device ID to be added to
>    > hid_blacklist[] in drivers/hid/hid-core.c as well. Otherwise the
>    > hid-egalax driver wouldn't bind to the device automatically in a
>    > proper way.
> 
> Thanks for noticing that; you're right, it's necessary.  I only tested
> CONFIG_HID_EGALAX=y, which doesn't seem to require the blacklist entry.
> I've tested that using the blacklist with =m works now.
> 
> Stéphane wrote:
>    > My suggestions:
>    >   - accept the patch, after adding a few comments in the code about
>    > this device requiring future care for its 'serial' protocol.
>    >   - start thinking about what changes are required in hid-input and/
>    > or hid-core for a more generic management of multitouch devices.
> 
> I've added a comment, feel free to reword it if you'd like to.  Thanks
> for the excellent research!

Thanks indeed.

I have now applied the patch.

-- 
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux