Hi, > >>>>> If a Kconfig option is needed for optionally compiling in the > support > >>>>> for am35x musb, it should be called USB_MUSB_AM35X or similar that > >>>>> gets selected if the boards using it are selected. > > >>>> Do you mean that we should have this option in > > >>> drivers/usb/musb/Kconfig? > > >>> Yeah, it could be set automatically with default y if > >>> MACH_AM35X_SOME_BOARD. > > >>> Then options like this should not be mutually exclusive like they > >>> currently are for musb, that breaks using musb with multi omap. > > >> Choosing USB_MUSB_AM35X would anyways compile am35x.c and not > omap2430.c > >> File; thus musb would not work on OMAP3x boards with same binary. > > > You should set up things so both can be compiled in, that's standard > > behaviour for all Linux drivers :) > > This is much easier said than done. Tony, As musb controllers are quite different between OMAPs and AM35x so it would be difficult in terms of software maintenance with such approach. Some of the major changes in AM35x are, - Has builtin USB PHY - It doesn't use Mentor DMA but uses CPPI4.1 DMA - Has set of wrapper register which are not present on OMAPs. - Doesn't have SYSCONFIG registers which are present on OMAPs. - Has bytewise read limitation which is not applicable to OMAPs. Musb on AM35x is actually quite similar to musb on DA8xx family of Devices. I can update the patches to use USB_MUSB_AM35X config within drivers/usb/musb/ but that would still not be able to compile in Both omapx and am35x stuff in single binary. Thanks, Ajay > > >> I will update the patches and submit for further reviews. > > > Thanks, > > Tony > > WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
