Hello. Tony Lindgren wrote:
AM35x has musb interface (version 1.8) and uses CPPI41 DMA engine. It has USB phy built inside the IP itself.
Also added ARCH_AM35x which is required to differentiate musb ips between OMAP3x and AM35x. This config would be used for below purposes, - Select am35x.c instead of omap2430.c for compilation at drivers/usb/musb directory. Please note there are significant differneces in these two files as musb ip in quite different on AM35x. - Select workaround codes applicable for AM35x musb issues. one such workaround is for bytewise read issue on AM35x.
<snip>
diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig index b31b6f1..52a6752 100644 --- a/arch/arm/mach-omap2/Kconfig +++ b/arch/arm/mach-omap2/Kconfig @@ -84,6 +84,7 @@ config MACH_OMAP3517EVM bool "OMAP3517/ AM3517 EVM board" depends on ARCH_OMAP3 select OMAP_PACKAGE_CBB + select ARCH_AM35x config MACH_OMAP3_PANDORA bool "OMAP3 Pandora"
No thanks..
--- a/arch/arm/plat-omap/Kconfig +++ b/arch/arm/plat-omap/Kconfig @@ -5,6 +5,14 @@ menu "TI OMAP Implementations" config ARCH_OMAP_OTG bool +config ARCH_AM35x + bool + help + Select this option if your platform is based on AM35x. As + AM35x has an updated MUSB with CPPI4.1 DMA so this config + is introduced to differentiate musb ip between OMAP3x and + AM35x platforms. + choice prompt "OMAP System Type" default ARCH_OMAP2PLUS
..this should not be needed.
I think Ajay has explained why it's needed. The option is necessary in one or another form.
It's not needed for omaps, we can already build in support for omap2, omap3 and omap4 into the same kernel binary.
Not with AM35x USB support merged -- at least you won't be able to build single kernel with monolithic MUSB support.
If a Kconfig option is needed for optionally compiling in the support for am35x musb, it should be called USB_MUSB_AM35X or similar that gets selected if the boards using it are selected.
Do you mean that we should have this option in drivers/usb/musb/Kconfig?
Regards, Tony
WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
