Hi, >________________________________________ >From: linux-usb-owner@xxxxxxxxxxxxxxx [linux-usb-owner@xxxxxxxxxxxxxxx] On Behalf Of Yann Cantin [yann.cantin@xxxxxxxxxxx] >Sent: Monday, May 24, 2010 6:06 AM >To: dbrownell@xxxxxxxxxxxxxxxxxxxxx >Cc: linux-usb@xxxxxxxxxxxxxxx >Subject: [PATCH] file_storage usb gadget : add serial number parameter > >Hi > >Add a parameter to file_storage usb gadget module to be able to specify >the serial number of a device (for example, the serial number of an >emulated usb stick). > >Things i'm not sure i've done well about : >- 12 chars limitation for CBI transport : I need more (24 chars) for sticks serial, so i've > modified the static serial declaration, and cut this string (\0 in serial[12]) if CBI is selected. >- i've keep the serial static, but now that it can be modified, perhaps it should be integrated > in the mod_data struct. >- DRIVER_SERIAL_NUM_NOT_SET : i need a way to know if the parameter have been passed, only find that. >- hexadecimal characters check : is there a better way ? >- The string copy handling between char array (serial) and char pointer (serial_parm). I'm not sure > it's rock-solid. >- I keep the dead (moved) code enclosed in /* */ >Be smart, it's my first day :) > >--- linux-2.6.31/drivers/usb/gadget/file_storage.c.orig 2009-09-10 00:13:59.000000000 +0200 >+++ linux-2.6.31/drivers/usb/gadget/file_storage.c 2010-05-24 01:30:44.000000000 +0200 Can you prepare a patch against linux-next ? or atleast the latest kernel ? Looks like you prepared it against 2.6.31 which is too old. Also, look at the storage_common.c and may be its already there what you are trying to add. >@@ -56,7 +56,7 @@ > * following protocols: RBC (0x01), ATAPI or SFF-8020i (0x02), QIC-157 (0c03), This Email may contain confidential or privileged information for the intended recipient (s) If you are not the intended recipient, please do not use or disseminate the information, notify the sender and delete it from your system. ______________________________________________________________________ -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
