On Wed, May 05, 2010 at 11:55:03PM +0200, Johan Hovold wrote: > On Fri, Apr 23, 2010 at 03:40:30PM -0700, Greg KH wrote: > > On Sun, Mar 21, 2010 at 05:36:18PM +0100, Johan Hovold wrote: > > > Hi again, > > > > > > Here's an updated version with the following modifications > > > > > > - Use lock versions of test_and_set_bit and clear_bit for > > > USB_SERIAL_WRITE_BUSY. > > > > > > - Make sure USB_SERIAL_WRITE_BUSY is cleared under the port lock if there are > > > no urbs free or no data in fifo. > > > > > > There is a theoretical possibility of receiving two interrupts after > > > checking for free urbs and fifo data but before clearing the flag, so > > > this must be done atomically. > > > > > > - Make sure ftdi_sio_close calls generic close to kill write urbs and clear > > > fifo. > > > > > > - Implement usb_serial_generic_resume. > > > > Looks great. Want to resend these so I can apply them? > > Here's a third version with the following changes made: > > - Add comments on new fields in struct usb_serial_port (and remove > comment on removed tx_urbs field). > - Do not export the now trivial generic prepare_write_buffer. > - A few minor cosmetic changes (e.g. changes variable names and removed > comment). Looks good, now queue up. > I also added my self as co-author of the generic usb-serial > implementation. Again, I hope that's ok. Yes, of course that is ok, thanks so much for this work, it is much appreciated. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
