Re: [RFC][PATCH v2 0/2] USB: serial: unify generic write implementations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Mar 21, 2010 at 05:36:18PM +0100, Johan Hovold wrote:
> Hi again, 
> 
> Here's an updated version with the following modifications
> 
>  - Use lock versions of test_and_set_bit and clear_bit for
>    USB_SERIAL_WRITE_BUSY.
> 
>  - Make sure USB_SERIAL_WRITE_BUSY is cleared under the port lock if there are
>    no urbs free or no data in fifo.
> 
>    There is a theoretical possibility of receiving two interrupts after
>    checking for free urbs and fifo data but before clearing the flag, so
>    this must be done atomically.
> 
>  - Make sure ftdi_sio_close calls generic close to kill write urbs and clear
>    fifo.
> 
>  - Implement usb_serial_generic_resume.

Looks great.  Want to resend these so I can apply them?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux