On Thu, Feb 18, 2010 at 02:28:13PM +0000, Matthew Garrett wrote: > On Thu, Feb 18, 2010 at 03:23:48PM +0100, Matthias Urlichs wrote: > > mjg: > > > > The option driver actually appears to perform some commands that > > > > are option-specific - if the other devices don't work the same way > > > > they probably /ought/ to be in a different driver, but it doesn't > > > > make any real difference. > > > > > Sure they work the same way. Minor differences, assuming that they > > actually matter, can easily be handled with device-specific options. Why > > duplicate the whole code? > > Where am I duplicating any code? This patchset exists to make it > possible to share the majority of the code without needing to share > device-specific code or add awkward conditionals - for instance, putting > the qcserial setup code directly in option would be kind of messy, but > qcserial would clearly benefit from the rest of the option driver > functionality. Exactly, I like these patches, and think they will help us a lot. Nice job. I'll go queue them up later today. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
