Re: Question regarding 5adc1cc038f4 ("usb: xhci: address off-by-one in xhci_num_trbs_free()")

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 08/01/2025 13.17, Oliver Neukum wrote:
> Hi,
> 
> I was wondering whether this patch should go
> into the stable tree. As far as I can see the issue
> it fixes is old. What do you think?
> 
>     Regards
>         Oliver
> 
> 

Hi Oliver,

My patch does not change any functionality. The extra loop was never
executed, and the function's return value remains unchanged [1].
I addressed this issue primarily for the benefit of developers.
While the function is straightforward, the extra loop is not.
Identifying its redundancy wastes time.

Since the patch does not fix a bug, it was not added to the stable tree.


[1], The first 'if' statement in the do-while loop will always trigger,
before the loop can terminate. Because a ring always has a Dequeue and
Enqueue pointer; they are integral to the core functionality of a ring.

Best Regards,
Niklas Neronin




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux