Johan Hovold - 11:49 8.01.25 wrote:
> On Tue, Jan 07, 2025 at 05:08:29PM +0100, Michal Hrusecky wrote:
> > Update the USB serial option driver to support Neoway N723-EA.
> >
> > ID 2949:8700 Marvell Mobile Composite Device Bus
> >
> > T: Bus=02 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 2 Spd=480 MxCh= 0
> > D: Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs= 1
> > P: Vendor=2949 ProdID=8700 Rev= 1.00
> > S: Manufacturer=Marvell
> > S: Product=Mobile Composite Device Bus
> > S: SerialNumber=200806006809080000
> > C:* #Ifs= 5 Cfg#= 1 Atr=c0 MxPwr=500mA
> > A: FirstIf#= 0 IfCount= 2 Cls=e0(wlcon) Sub=01 Prot=03
> > I:* If#= 0 Alt= 0 #EPs= 1 Cls=e0(wlcon) Sub=01 Prot=03 Driver=rndis_host
> > E: Ad=87(I) Atr=03(Int.) MxPS= 64 Ivl=4096ms
> > I:* If#= 1 Alt= 0 #EPs= 2 Cls=0a(data ) Sub=00 Prot=00 Driver=rndis_host
> > E: Ad=83(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > E: Ad=0c(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > I:* If#= 2 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
> > E: Ad=89(I) Atr=03(Int.) MxPS= 64 Ivl=4096ms
> > E: Ad=82(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > E: Ad=0b(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > I:* If#= 4 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
> > E: Ad=86(I) Atr=03(Int.) MxPS= 64 Ivl=4096ms
> > E: Ad=85(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > E: Ad=0e(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > I:* If#= 6 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
> > E: Ad=88(I) Atr=03(Int.) MxPS= 64 Ivl=4096ms
> > E: Ad=81(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > E: Ad=0a(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> >
> > Tested successfully connecting to the Internet via rndis interface after
> > dialing via AT commands on If#=4 or If#=6.
> >
> > Not sure of the purpose of the other serial interface.
> >
> > Signed-off-by: Michal Hrusecky <michal.hrusecky@xxxxxxxxxx>
> > ---
> > drivers/usb/serial/option.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> > index 64317b390d22..758f02f0d2b9 100644
> > --- a/drivers/usb/serial/option.c
> > +++ b/drivers/usb/serial/option.c
> > @@ -2412,6 +2412,7 @@ static const struct usb_device_id option_ids[] = {
> > .driver_info = NCTRL(1) },
> > { USB_DEVICE_INTERFACE_CLASS(0x1bbb, 0x0640, 0xff), /* TCL IK512 ECM */
> > .driver_info = NCTRL(3) },
> > + { USB_DEVICE(0x2949, 0x8700) }, /* Neoway N723-EA */
>
> This should be USB_DEVICE_INTERFACE_CLASS() to avoid trying to bind to
> the rndis interfaces.
>
> I fixed this up when applying.
Ah, sorry for the inconvenience and thank you very much!
Michal
