On Wed, 13 Jan 2010, Oliver Neukum wrote: > Am Mittwoch, 13. Januar 2010 17:41:29 schrieb Alan Stern: > > > + > > > if (file->f_mode & FMODE_READ) > > > poll_wait(file, &deviceconndiscwq, wait); > > > if (st->lastev != conndiscevcnt) > > > mask |= POLLIN; > > > st->lastev = conndiscevcnt; > > > - unlock_kernel(); > > > + mutex_unlock(&usbfs_mutex); > > > return mask; > > > } > > > > And could this be simplified by storing the count directly in > > file->private_data rather than allocating it separately > > This is possible, but file->private_data is a pointer. Do we really > want to use it to store an integer? Sure, why not? The count value _is_ private data, after all. And besides, that's exactly what ERR_PTR and PTR_ERR do. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
