Re: [PATCH 1/5] usb:Remove BKL from poll()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am Mittwoch, 13. Januar 2010 17:41:29 schrieb Alan Stern:
> > +
> >       if (file->f_mode & FMODE_READ)
> >               poll_wait(file, &deviceconndiscwq, wait);
> >       if (st->lastev != conndiscevcnt)
> >               mask |= POLLIN;
> >       st->lastev = conndiscevcnt;
> > -     unlock_kernel();
> > +     mutex_unlock(&usbfs_mutex);
> >       return mask;
> >  }
> 
> And could this be simplified by storing the count directly in 
> file->private_data rather than allocating it separately

This is possible, but file->private_data is a pointer. Do we really
want to use it to store an integer?

	Regards
		Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux