On Mon, Oct 28, 2024 at 04:04:15PM +0800, wojackbb@xxxxxxxxx wrote: > From: Jack Wu <wojackbb@xxxxxxxxx> > > Add the MediaTek T7XX compositions: Can you say something about what the various interfaces are used for here? > T: Bus=03 Lev=01 Prnt=01 Port=05 Cnt=01 Dev#= 74 Spd=480 MxCh= 0 > D: Ver= 2.10 Cls=ef(misc ) Sub=02 Prot=01 MxPS=64 #Cfgs= 1 > P: Vendor=0e8d ProdID=7129 Rev= 0.01 > S: Manufacturer=MediaTek Inc. > S: Product=USB DATA CARD > S: SerialNumber=004402459035402 > C:* #Ifs=10 Cfg#= 1 Atr=a0 MxPwr=500mA > Signed-off-by: Jack Wu <wojackbb@xxxxxxxxx> > --- > drivers/usb/serial/option.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c > index 4f18f189f309..b6118f545386 100644 > --- a/drivers/usb/serial/option.c > +++ b/drivers/usb/serial/option.c > @@ -2244,6 +2244,7 @@ static const struct usb_device_id option_ids[] = { > .driver_info = NCTRL(2) }, > { USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, 0x7127, 0xff, 0x00, 0x00), > .driver_info = NCTRL(2) | NCTRL(3) | NCTRL(4) }, > + { USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, 0x7129, 0xff, 0x00, 0x00) }, /* MediaTek T7XX */ Should you mark some of the interfaces are not accepting modem control requests similar to 0x7126 and 0x7127? > { USB_DEVICE(CELLIENT_VENDOR_ID, CELLIENT_PRODUCT_MEN200) }, > { USB_DEVICE(CELLIENT_VENDOR_ID, CELLIENT_PRODUCT_MPL200), > .driver_info = RSVD(1) | RSVD(4) }, Johan