On Mon, Oct 28, 2024 at 04:19:49PM +0800, wojackbb@xxxxxxxxx wrote:
> From: Jack Wu <wojackbb@xxxxxxxxx>
>
> Add support for Sierra Wireless EM86xx with
> USB-id 0x1199:0x90e5 & 0x1199:0x90e4.
> Signed-off-by: Jack Wu <wojackbb@xxxxxxxxx>
> ---
I had another patch in my inbox from you adding these ids so this is a
v2. This should be indicated in the patch summary (e.g. "[PATCH v2] USB:
serial: ...) and by adding a short changelog here describing what
changed from the previous versions.
> drivers/usb/serial/qcserial.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/usb/serial/qcserial.c b/drivers/usb/serial/qcserial.c
> index c7de9585feb2..933589ba5869 100644
> --- a/drivers/usb/serial/qcserial.c
> +++ b/drivers/usb/serial/qcserial.c
> @@ -168,6 +168,8 @@ static const struct usb_device_id id_table[] = {
> {DEVICE_SWI(0x1199, 0x90d2)}, /* Sierra Wireless EM9191 QDL */
> {DEVICE_SWI(0x1199, 0xc080)}, /* Sierra Wireless EM7590 QDL */
> {DEVICE_SWI(0x1199, 0xc081)}, /* Sierra Wireless EM7590 */
> + {DEVICE_SWI(0x1199, 0x90e4)}, /* Sierra Wireless EM86xx QDL*/
> + {DEVICE_SWI(0x1199, 0x90e5)}, /* Sierra Wireless EM86xx */
Also try to keep the entries sorted by PID.
> {DEVICE_SWI(0x413c, 0x81a2)}, /* Dell Wireless 5806 Gobi(TM) 4G LTE Mobile Broadband Card */
> {DEVICE_SWI(0x413c, 0x81a3)}, /* Dell Wireless 5570 HSPA+ (42Mbps) Mobile Broadband Card */
> {DEVICE_SWI(0x413c, 0x81a4)}, /* Dell Wireless 5570e HSPA+ (42Mbps) Mobile Broadband Card */
Please fix this up in a v3.
Johan
