Re: [PATCH v3 2/2] arm64: dts: mediatek: mt8395-genio-1200-evk: add support for MUX IT5205

[AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>]

Il 23/10/24 10:09, Macpaul Lin ha scritto:
> Add ITE IT5205FN (TYPEC MUX) under I2C2 bus and configure its properties;
> also add references to it5205fn from MT6360 TYPE-C connector for TYPEC
> configuration.
>
> Signed-off-by: Fabien Parent <fparent@xxxxxxxxxxxx>
> Signed-off-by: Simon Sun <simon.sun@xxxxxxxxxxxxxxx>
> Signed-off-by: Macpaul Lin <macpaul.lin@xxxxxxxxxxxx>
> ---
>   .../dts/mediatek/mt8395-genio-1200-evk.dts    | 22 +++++++++++++++++++
>   1 file changed, 22 insertions(+)
>
> Changes for v2:
>   - This is a new patch in the v2 patch.
>
> Changes for v3:
>   - No change.
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8395-genio-1200-evk.dts b/arch/arm64/boot/dts/mediatek/mt8395-genio-1200-evk.dts
> index 83d520226302..4c11c100e7b6 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8395-genio-1200-evk.dts
> +++ b/arch/arm64/boot/dts/mediatek/mt8395-genio-1200-evk.dts
> @@ -229,6 +229,21 @@ &i2c2 {
>   	pinctrl-0 = <&i2c2_pins>;
>   	pinctrl-names = "default";
>   	status = "okay";
> +
> +	it5205fn: typec-mux@48 {

You don't need the it5205fn phandle, please drop.

> +		compatible = "ite,it5205";
> +		reg = <0x48>;
> +		vcc-supply = <&mt6359_vibr_ldo_reg>;
> +		mode-switch;
> +		orientation-switch;

compatible
reg
mode-switch
orientation-switch
vcc-supply

Please reorder.

After which:

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>

> +		status = "okay";
> +
> +		port {
> +			it5205_sbu_ep: endpoint {
> +				remote-endpoint = <&mt6360_ssusb_sbu_ep>;
> +			};
> +		};
> +	};
>   };
>   
>   &i2c6 {
> @@ -369,6 +384,13 @@ mt6360_ssusb_ep: endpoint {
>   							remote-endpoint = <&ssusb_ep>;
>   						};
>   					};
> +
> +					port@2 {
> +						reg = <2>;
> +						mt6360_ssusb_sbu_ep: endpoint {
> +							remote-endpoint = <&it5205_sbu_ep>;
> +						};
> +					};
>   				};
>   			};
>   		};