Hi, On Thu, 4 Apr 2024 at 11:42, Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > > On 04/04/2024 06:27, Anand Moon wrote: > > Hi Krzysztof, > > > > On Tue, 12 Dec 2023 at 18:47, Anand Moon <linux.amoon@xxxxxxxxx> wrote: > >> > >> Hi Krzysztof, > >> > >> On Tue, 12 Dec 2023 at 18:39, Krzysztof Kozlowski > >> <krzysztof.kozlowski@xxxxxxxxxx> wrote: > >>> > >>> On 12/12/2023 13:51, Anand Moon wrote: > >>>> Hi Krzysztof, > >>>> > >>>> On Tue, 12 Dec 2023 at 17:22, Krzysztof Kozlowski > >>>> <krzysztof.kozlowski@xxxxxxxxxx> wrote: > >>>>> > >>>>> On 12/12/2023 12:37, Anand Moon wrote: > >>>>>> > >>>>>> Here is the list of warnings I observed with this patch > >>>>>> > >>>>>> DTC_CHK Documentation/devicetree/bindings/usb/nvidia,tegra186-xusb.example.dtb > >>>>>> /home/amoon/mainline/linux-amlogic-6.y-devel/Documentation/devicetree/bindings/usb/usb-device.example.dtb: > >>>>>> hub@1: 'vdd-supply' is a required property > >>>>> > >>>>> You always require the property, but it is not valid for some devices. > >>>>> Just require it only where it is applicable (in if:then: clause). > >>>>> > >>>> I had already done this check many times before. > >>> > >>> I don't ask you to check. I ask you to change the code. > >>> > >> I have tried this and it's not working for me. > >> > >>>> my v6 original patch was doing the same and it passed all the tests > >>>> but since I updated the required field it not parsing correctly. > >>> > >>> Your original v6 patch was different. I don't understand what you are > >>> trying to achieve. Or rather: how is it different, that my simple advice > >>> above does not work for you (as in the past you reply with some really > >>> unrelated sentence). > >>> > >> Ok, It's my poor English grammar, thanks for your review comments. > >> > >>> Best regards, > >>> Krzysztof > >>> > > > > Any reason this device tree binding got removed,I cannot find this file > > Can not find the commit which removed this file. > > Use git log. > > Best regards, > Krzysztof >
