On 08/12/2023 12:19, Anand Moon wrote: > Hi Krzysztof, > > On Fri, 8 Dec 2023 at 13:14, Krzysztof Kozlowski > <krzysztof.kozlowski@xxxxxxxxxx> wrote: >> >> On 08/12/2023 01:24, Anand Moon wrote: >>>>>>> >>>>>>> If I move reset-gpios to required, I observe the below warning. >>>>>>> >>>>>>> DTC_CHK Documentation/devicetree/bindings/usb/maxim,max33359.example.dtb >>>>>>> /home/alarm/linux-amlogic-5.y-devel/Documentation/devicetree/bindings/usb/usb-device.example.dtb: >>>>>>> hub@1: 'reset-gpio' is a required property >>>>>>> from schema $id: http://devicetree.org/schemas/usb/genesys,gl850g.yaml# >>>>>> >>>>>> Where are the properties defined? If you open the binding you see: >>>>>> nowhere. You cannot define properties in some variant with "true". >>>>>> Please define all of them in top-level and only narrow/constrain when >>>>>> applicable. >>>>>> >>>>> What I meant is the example below, required meant applicable for both >>>>> the binding >>>>> But it shows me the above warning. >>>> >>>> My explanation stands... So again: >>>> >>>>>> Please define all of them in top-level and only narrow/constrain when >>>>>> applicable. >>>> >>> Apologies, But I have tried this multiple times but have not been able >>> to fix the device tree warning >> >> Did you document all properties in top-level "properties:" block? >> > Yes, I have, > > Can you suggest a couple of examples to follow? > I looked at some of the YAML files but could not fix my issue. 99% of bindings. Look also at example-schema. You can also attach here complete patch for fast look / short review. Best regards, Krzysztof