Hi Krzysztof, On Tue, 12 Dec 2023 at 17:22, Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > > On 12/12/2023 12:37, Anand Moon wrote: > > > > Here is the list of warnings I observed with this patch > > > > DTC_CHK Documentation/devicetree/bindings/usb/nvidia,tegra186-xusb.example.dtb > > /home/amoon/mainline/linux-amlogic-6.y-devel/Documentation/devicetree/bindings/usb/usb-device.example.dtb: > > hub@1: 'vdd-supply' is a required property > > You always require the property, but it is not valid for some devices. > Just require it only where it is applicable (in if:then: clause). > I had already done this check many times before. my v6 original patch was doing the same and it passed all the tests but since I updated the required field it not parsing correctly. required: - compatible - reg - vdd-supply - reset-gpios - peer-hub > > > from schema $id: http://devicetree.org/schemas/usb/genesys,gl850g.yaml# > > /home/amoon/mainline/linux-amlogic-6.y-devel/Documentation/devicetree/bindings/usb/usb-device.example.dtb: > > hub@1: 'reset-gpios' is a required property > > from schema $id: http://devicetree.org/schemas/usb/genesys,gl850g.yaml# > > /home/amoon/mainline/linux-amlogic-6.y-devel/Documentation/devicetree/bindings/usb/usb-device.example.dtb: > > hub@1: 'peer-hub' is a required property > > ... > > >>> + - if: > >>> + properties: > >>> + compatible: > >>> + contains: > >>> + enum: > >>> + - usb5e3,610 > >>> + - usb5e3,620 > >>> + then: > >>> + properties: > >>> + peer-hub: true > >>> + vdd-supply: true > >> > >> Drop this if:, redundant. > >> > > No, this does not resolve the above issue. > > It shouldn't resolve it, not related. > ok > > Best regards, > Krzysztof Thanks -Anand
