Re: [PATCH] cdc_acm: add reset_resume method

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am Montag, 7. Dezember 2009 19:25:14 schrieb Francesco Lavra:
> --- a/drivers/usb/class/cdc-acm.c       2009-12-07 16:22:20.000000000 +0100
> +++ b/drivers/usb/class/cdc-acm.c       2009-12-07 19:11:43.000000000 +0100
> @@ -1460,6 +1460,23 @@ err_out:
>         return rv;
>  }
>  
> +static int acm_reset_resume(struct usb_interface *intf)
> +{
> +       struct acm *acm = usb_get_intfdata(intf);
> +       struct tty_struct *tty;
> +
> +       mutex_lock(&open_mutex);

That you must not do. acm_tty_open() calls usb_autopm_get_interface()
with open_mutex held. For any device with USB_QUIRK_RESET_RESUME
this can deadlock.

	Regards
		Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux