Hi Conor, On Thu, 30 Nov 2023 at 20:52, Conor Dooley <conor@xxxxxxxxxx> wrote: > > On Thu, Nov 30, 2023 at 03:16:33PM +0000, Conor Dooley wrote: > > On Thu, Nov 30, 2023 at 11:01:26AM +0530, Anand Moon wrote: > > > Add the binding example for the USB3.1 Genesys Logic GL3523 > > > integrates with USB 3.1 Gen 1 Super Speed and USB 2.0 High-Speed > > > hub. > > > > > > For onboard hub controllers that support USB 3.x and USB 2.0 hubs > > > with shared resets and power supplies, this property is used to identify > > > the hubs with which these are shared. > > > > > > > > [Conor Dooley: upgrade peer-hub description] > > ok > > This should not be in the commit message. Otherwise, > > Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> > > > > Cheers, > > Conor. > > > > > Signed-off-by: Anand Moon <linux.amoon@xxxxxxxxx> > > > --- > > > v5: upgrade peer-hub description : Conor Dooley > > > [0] https://www.genesyslogic.com.tw/en/product_view.php?show=67 [Block Diagram] > > > v4: Fix the description of peer-hub and update the commit message. > > > Schematics of the Odroid N2+ > > > https://dn.odroid.com/S922X/ODROID-N2/Schematic/odroid-n2_rev0.6_20210121.pdf > > > V3: fix the dt_binding_check error, added new example for Genesys GL3523 > > > v2: added Genesys GL3523 binding > > > v1: none > > > --- > > > .../bindings/usb/genesys,gl850g.yaml | 65 +++++++++++++++++-- > > > 1 file changed, 61 insertions(+), 4 deletions(-) > > > > > > diff --git a/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml b/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml > > > index ee08b9c3721f..499192ea4074 100644 > > > --- a/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml > > > +++ b/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml > > > @@ -9,9 +9,6 @@ title: Genesys Logic USB hub controller > > > maintainers: > > > - Icenowy Zheng <uwu@xxxxxxxxxx> > > > > > > -allOf: > > > - - $ref: usb-device.yaml# > > > - > > > properties: > > > compatible: > > > enum: > > > @@ -27,12 +24,46 @@ properties: > > > > > > vdd-supply: > > > description: > > > - the regulator that provides 3.3V core power to the hub. > > > + phandle to the regulator that provides power to the hub. > > Wait, why is this text changing? I don't see it mentioned anywhere why > this is no longer specifically 3.3v > GL3523 has built-in 5V to 3.3V and 5V to 1.2V regulators, which saves customers’ BOM cost, and eases for PCB design. Do I have to update this in the commit message? or leave this original. > Thanks, > Conor. > Thanks -Anand
