On Thu, Nov 30, 2023 at 03:16:33PM +0000, Conor Dooley wrote: > On Thu, Nov 30, 2023 at 11:01:26AM +0530, Anand Moon wrote: > > Add the binding example for the USB3.1 Genesys Logic GL3523 > > integrates with USB 3.1 Gen 1 Super Speed and USB 2.0 High-Speed > > hub. > > > > For onboard hub controllers that support USB 3.x and USB 2.0 hubs > > with shared resets and power supplies, this property is used to identify > > the hubs with which these are shared. > > > > > [Conor Dooley: upgrade peer-hub description] > > This should not be in the commit message. Otherwise, > Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> > > Cheers, > Conor. > > > Signed-off-by: Anand Moon <linux.amoon@xxxxxxxxx> > > --- > > v5: upgrade peer-hub description : Conor Dooley > > [0] https://www.genesyslogic.com.tw/en/product_view.php?show=67 [Block Diagram] > > v4: Fix the description of peer-hub and update the commit message. > > Schematics of the Odroid N2+ > > https://dn.odroid.com/S922X/ODROID-N2/Schematic/odroid-n2_rev0.6_20210121.pdf > > V3: fix the dt_binding_check error, added new example for Genesys GL3523 > > v2: added Genesys GL3523 binding > > v1: none > > --- > > .../bindings/usb/genesys,gl850g.yaml | 65 +++++++++++++++++-- > > 1 file changed, 61 insertions(+), 4 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml b/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml > > index ee08b9c3721f..499192ea4074 100644 > > --- a/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml > > +++ b/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml > > @@ -9,9 +9,6 @@ title: Genesys Logic USB hub controller > > maintainers: > > - Icenowy Zheng <uwu@xxxxxxxxxx> > > > > -allOf: > > - - $ref: usb-device.yaml# > > - > > properties: > > compatible: > > enum: > > @@ -27,12 +24,46 @@ properties: > > > > vdd-supply: > > description: > > - the regulator that provides 3.3V core power to the hub. > > + phandle to the regulator that provides power to the hub. Wait, why is this text changing? I don't see it mentioned anywhere why this is no longer specifically 3.3v Thanks, Conor. > > + > > + peer-hub: > > + $ref: /schemas/types.yaml#/definitions/phandle > > + description: > > + For onboard hub controllers that support USB 3.x and USB 2.0 hubs > > + with shared resets and power supplies, this property is used to identify > > + the hubs with which these are shared. > > > > required: > > - compatible > > - reg > > > > +allOf: > > + - $ref: usb-device.yaml# > > + - if: > > + properties: > > + compatible: > > + contains: > > + enum: > > + - usb5e3,608 > > + then: > > + properties: > > + peer-hub: false > > + vdd-supply: false > > + reset-gpios: true > > + > > + - if: > > + properties: > > + compatible: > > + contains: > > + enum: > > + - usb5e3,610 > > + - usb5e3,620 > > + then: > > + properties: > > + peer-hub: true > > + vdd-supply: true > > + reset-gpios: true > > + > > additionalProperties: false > > > > examples: > > @@ -49,3 +80,29 @@ examples: > > reset-gpios = <&pio 7 2 GPIO_ACTIVE_LOW>; > > }; > > }; > > + > > + - | > > + #include <dt-bindings/gpio/gpio.h> > > + usb { > > + dr_mode = "host"; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + /* 2.0 hub on port 1 */ > > + hub_2_0: hub@1 { > > + compatible = "usb5e3,610"; > > + reg = <1>; > > + peer-hub = <&hub_3_0>; > > + reset-gpios = <&gpio 20 GPIO_ACTIVE_LOW>; > > + vdd-supply = <&vcc_5v>; > > + }; > > + > > + /* 3.1 hub on port 4 */ > > + hub_3_0: hub@2 { > > + compatible = "usb5e3,620"; > > + reg = <2>; > > + peer-hub = <&hub_2_0>; > > + reset-gpios = <&gpio 20 GPIO_ACTIVE_LOW>; > > + vdd-supply = <&vcc_5v>; > > + }; > > + }; > > -- > > 2.42.0 > >
Attachment:
signature.asc
Description: PGP signature
