On 21.8.2023 9.57, Basavaraj Natikar wrote:
The USB host controller (1022:43f7) isn't going into PCI D3 by default
without anything connected. This is because the policy that was introduced
by commit a611bf473d1f ("xhci-pci: Set runtime PM as default policy on all
xHC 1.2 or later devices") only covered 1.2 or later.
The 1.1 specification also has the same requirement as the 1.2
specification for D3 support. So expand the runtime PM as default policy
to 1.1 devices as well.
I'm a bit hesitant to change the default policy for this many hosts in one go.
This affects all vendors.
I see a regression risk in this.
Many xhci issues have been related to runtime pm.
We do have a list of selected Intel xHCI 1.1 host that have enabled runtime pm
by default. Same could be done for 1022:43f7
Or if you are confident all AMD xHC 1.1 hosts can have this enabled, then that
works as well:
if (pdev->vendor == PCI_VENDOR_ID_AMD && xhci->hci_version >= 0x110)
xhci->quirks |= XHCI_DEFAULT_PM_RUNTIME_ALLOW;
Thanks
Mathias
