RE: additional debug output for autosuspend in cdc-ether

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

I think you are on to something here. Testing the last correction below, and including
the extra msleep(50); before the usb_mark_last_busy(udev); in the remote_wakeup()
function within hub.c. I have not seen any XactErr or USB resets triggered by remote wakeup
in over 5000 cycles. I will need to keep running until I hit something around 10000 cycles until
I can judge it stable.

BR,
Rickard

-----Original Message-----
From: Oliver Neukum [mailto:oliver@xxxxxxxxxx] 
Sent: den 24 november 2009 17:32
To: Rickard Bellini
Cc: Alan Stern; linux-usb@xxxxxxxxxxxxxxx; Torgny Johansson
Subject: Re: additional debug output for autosuspend in cdc-ether

Am Dienstag, 24. November 2009 09:14:40 schrieb Rickard Bellini:
> Hi,
> 
> I'm sorry, I might have missed some information in this thread.
> Did you want me to test anything with regards to the remote wakeup 
> problem?

Hi,

sorry for being unclear. We were discusssing possible causes for your problem. It looks like your device is flaky with respect to remote wakeup. As this problem strikes rarely it is possible that your device will work if we give it a bit more time.
The attached debugging patch does this. Could you test it?

	Regards
		Oliver

--

commit e9670520fdb98dbc4f500e57681bc534576e3a68
Author: Oliver Neukum <oliver@xxxxxxxxxx>
Date:   Tue Nov 24 09:30:21 2009 +0100

    longer period for remote wakeup for debugging.

diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c index 9835e07..ad5e50b 100644
--- a/drivers/usb/host/ehci-hcd.c
+++ b/drivers/usb/host/ehci-hcd.c
@@ -785,7 +785,7 @@ static irqreturn_t ehci_irq (struct usb_hcd *hcd)
 			 * and make khubd collect PORT_STAT_C_SUSPEND to
 			 * stop that signaling.
 			 */
-			ehci->reset_done [i] = jiffies + msecs_to_jiffies (20);
+			ehci->reset_done [i] = jiffies + msecs_to_jiffies (200);
 			ehci_dbg (ehci, "port %d remote wakeup\n", i + 1);
 			mod_timer(&hcd->rh_timer, ehci->reset_done[i]);
 		}
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux