> -----Original Message----- > From: Sergei Shtylyov [mailto:sshtylyov@xxxxxxxxxxxxx] > Sent: Monday, November 23, 2009 8:15 PM > To: Gadiyar, Anand > Cc: linux-usb@xxxxxxxxxxxxxxx; Greg KH > Subject: Re: MUSB: loading g_ether causes crash > > Hello. > > Gadiyar, Anand wrote: > > > Sergei, > > > I'm seeing a crash on OMAP3430 after loading g_ether with a > > USB cable connected. Crash log is attached. This is on > > linux-omap kernel + Greg's usb.current and usb queues. > > > I've bisected it down to the following patch from you which > > is currently in the usb queue: > > usb-musb_gadget-remove-pointless-loop.patch [1] > > > Without this patch , I don't see a crash. > > Thanks for finding an issue! > > > I'll try and dig deeper tomorrow, but if you already know > > what the problem is, let me know. > > I think I'm seeing it -- it's my wrong optimization at end of > musb_g_tx(). I'll send an updated patch in a jiffy. > Thanks! Found the bug :) Also, just noticed you need braces around that else clause in that place. (so says Documentation/CodingStyle) - Anand -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
