patch usb-twl4030-enable-usb-regulators-before-enabling-usb-charging.patch added to gregkh-2.6 tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is a note to let you know that I've just added the patch titled

    Subject: USB: twl4030: Enable USB regulators before enabling USB charging

to my gregkh-2.6 tree.  Its filename is

    usb-twl4030-enable-usb-regulators-before-enabling-usb-charging.patch

This tree can be found at 
    http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/patches/


>From leed.aguilar@xxxxxx  Fri Nov 20 13:10:53 2009
From: "Aguilar Pena, Leed" <leed.aguilar@xxxxxx>
Date: Fri, 20 Nov 2009 11:32:53 -0600
Subject: USB: twl4030: Enable USB regulators before enabling USB charging
To: "linux-usb@xxxxxxxxxxxxxxx" <linux-usb@xxxxxxxxxxxxxxx>
Cc: "dbrownell@xxxxxxxxxxxxxxxxxxxxx" <dbrownell@xxxxxxxxxxxxxxxxxxxxx>, "gregkh@xxxxxxx" <gregkh@xxxxxxx>
Message-ID: <23D0CDE7C386D144A4F26EB0F427F8C074D70BE5@xxxxxxxxxxxxxxxxx>


For TWL family of power management ICs, USB charging works only
when USB regulators are in enabled state: 3v1, 1v5, 1v8

On a USB cable attach, twl4030_phy_resume(twl) function enables
the regulators. Enable USB charging, only after all regulators
are enabled.

Its observed that enabling USB charging before regulators are
enabled, causes USB charging to fail.

Tested on: Zoom2: omap3430: ES3.1 + TWL5030
Needs T2-MADC and T2-BCI drivers which are still not upstreamed.

Signed-off-by: Moiz Sonasath <m-sonasath@xxxxxx>
Signed-off-by: Leed Aguilar <leed.aguilar@xxxxxx>
Acked-by: Vikram Pandita <vikram.pandita@xxxxxx>
Acked-by: Anand Gadiyar <gadiyar@xxxxxx>
Acked-by: Nishanth Menon <nm@xxxxxx>
Acked-by: Felipe Balbi <felipe.balbi@xxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxx>


---
 drivers/usb/otg/twl4030-usb.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- a/drivers/usb/otg/twl4030-usb.c
+++ b/drivers/usb/otg/twl4030-usb.c
@@ -598,12 +598,12 @@ static irqreturn_t twl4030_usb_irq(int i
 		 * USB_LINK_VBUS state.  musb_hdrc won't care until it
 		 * starts to handle softconnect right.
 		 */
-		twl4030charger_usb_en(status == USB_LINK_VBUS);
-
 		if (status == USB_LINK_NONE)
 			twl4030_phy_suspend(twl, 0);
 		else
 			twl4030_phy_resume(twl);
+
+		twl4030charger_usb_en(status == USB_LINK_VBUS);
 	}
 	sysfs_notify(&twl->dev->kobj, NULL, "vbus");
 

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux