On Thu, May 18, 2023, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart from
> emitting a warning) and this typically results in resource leaks. To improve
> here there is a quest to make the remove callback return void. In the first
> step of this quest all drivers are converted to .remove_new() which already
> returns void. Eventually after all drivers are converted, .remove_new() is
> renamed to .remove().
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> ---
> drivers/usb/dwc3/dwc3-am62.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/usb/dwc3/dwc3-am62.c b/drivers/usb/dwc3/dwc3-am62.c
> index cda9458c809b..1755f2f848c5 100644
> --- a/drivers/usb/dwc3/dwc3-am62.c
> +++ b/drivers/usb/dwc3/dwc3-am62.c
> @@ -275,7 +275,7 @@ static int dwc3_ti_remove_core(struct device *dev, void *c)
> return 0;
> }
>
> -static int dwc3_ti_remove(struct platform_device *pdev)
> +static void dwc3_ti_remove(struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> struct dwc3_data *data = platform_get_drvdata(pdev);
> @@ -294,7 +294,6 @@ static int dwc3_ti_remove(struct platform_device *pdev)
> pm_runtime_set_suspended(dev);
>
> platform_set_drvdata(pdev, NULL);
> - return 0;
> }
>
> #ifdef CONFIG_PM
> @@ -362,7 +361,7 @@ MODULE_DEVICE_TABLE(of, dwc3_ti_of_match);
>
> static struct platform_driver dwc3_ti_driver = {
> .probe = dwc3_ti_probe,
> - .remove = dwc3_ti_remove,
> + .remove_new = dwc3_ti_remove,
> .driver = {
> .name = "dwc3-am62",
> .pm = DEV_PM_OPS,
> --
> 2.39.2
>
Acked-by: Thinh Nguyen <Thinh.Nguyen@xxxxxxxxxxxx>
Thanks,
Thinh
