On Thu, May 18, 2023, Uwe Kleine-König wrote: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is ignored (apart from > emitting a warning) and this typically results in resource leaks. To improve > here there is a quest to make the remove callback return void. In the first > step of this quest all drivers are converted to .remove_new() which already > returns void. Eventually after all drivers are converted, .remove_new() is > renamed to .remove(). > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> > --- > drivers/usb/dwc3/dwc3-st.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/usb/dwc3/dwc3-st.c b/drivers/usb/dwc3/dwc3-st.c > index fea5290de83f..211360eee95a 100644 > --- a/drivers/usb/dwc3/dwc3-st.c > +++ b/drivers/usb/dwc3/dwc3-st.c > @@ -305,7 +305,7 @@ static int st_dwc3_probe(struct platform_device *pdev) > return ret; > } > > -static int st_dwc3_remove(struct platform_device *pdev) > +static void st_dwc3_remove(struct platform_device *pdev) > { > struct st_dwc3 *dwc3_data = platform_get_drvdata(pdev); > > @@ -313,8 +313,6 @@ static int st_dwc3_remove(struct platform_device *pdev) > > reset_control_assert(dwc3_data->rstc_pwrdn); > reset_control_assert(dwc3_data->rstc_rst); > - > - return 0; > } > > #ifdef CONFIG_PM_SLEEP > @@ -364,7 +362,7 @@ MODULE_DEVICE_TABLE(of, st_dwc3_match); > > static struct platform_driver st_dwc3_driver = { > .probe = st_dwc3_probe, > - .remove = st_dwc3_remove, > + .remove_new = st_dwc3_remove, > .driver = { > .name = "usb-st-dwc3", > .of_match_table = st_dwc3_match, > -- > 2.39.2 > Acked-by: Thinh Nguyen <Thinh.Nguyen@xxxxxxxxxxxx> Thanks, Thinh