On Thu, May 18, 2023, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart from
> emitting a warning) and this typically results in resource leaks. To improve
> here there is a quest to make the remove callback return void. In the first
> step of this quest all drivers are converted to .remove_new() which already
> returns void. Eventually after all drivers are converted, .remove_new() is
> renamed to .remove().
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> ---
> drivers/usb/dwc3/dwc3-xilinx.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/usb/dwc3/dwc3-xilinx.c b/drivers/usb/dwc3/dwc3-xilinx.c
> index 2c36f97652ca..19307d24f3a0 100644
> --- a/drivers/usb/dwc3/dwc3-xilinx.c
> +++ b/drivers/usb/dwc3/dwc3-xilinx.c
> @@ -305,7 +305,7 @@ static int dwc3_xlnx_probe(struct platform_device *pdev)
> return ret;
> }
>
> -static int dwc3_xlnx_remove(struct platform_device *pdev)
> +static void dwc3_xlnx_remove(struct platform_device *pdev)
> {
> struct dwc3_xlnx *priv_data = platform_get_drvdata(pdev);
> struct device *dev = &pdev->dev;
> @@ -318,8 +318,6 @@ static int dwc3_xlnx_remove(struct platform_device *pdev)
> pm_runtime_disable(dev);
> pm_runtime_put_noidle(dev);
> pm_runtime_set_suspended(dev);
> -
> - return 0;
> }
>
> static int __maybe_unused dwc3_xlnx_runtime_suspend(struct device *dev)
> @@ -388,7 +386,7 @@ static const struct dev_pm_ops dwc3_xlnx_dev_pm_ops = {
>
> static struct platform_driver dwc3_xlnx_driver = {
> .probe = dwc3_xlnx_probe,
> - .remove = dwc3_xlnx_remove,
> + .remove_new = dwc3_xlnx_remove,
> .driver = {
> .name = "dwc3-xilinx",
> .of_match_table = dwc3_xlnx_of_match,
> --
> 2.39.2
>
Acked-by: Thinh Nguyen <Thinh.Nguyen@xxxxxxxxxxxx>
Thanks,
Thinh
