Hi Pawel, I love your patch! Perhaps something to improve: [auto build test WARNING on usb/usb-testing] [also build test WARNING on usb/usb-next usb/usb-linus westeri-thunderbolt/next soc/for-next linus/master v6.2-rc8 next-20230217] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Pawel-Laszczak/usb-cdns2-Device-side-header-file-for-CDNS2-driver/20230216-195428 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing patch link: https://lore.kernel.org/r/20230216105411.364157-4-pawell%40cadence.com patch subject: [PATCH 3/4] usb: cdns2: Add tracepoints for CDNS2 driver config: ia64-allmodconfig (https://download.01.org/0day-ci/archive/20230219/202302190436.AU6zwie0-lkp@xxxxxxxxx/config) compiler: ia64-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/edb55f1c0a0ffe341211e08b1ebf162f48dd5b83 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Pawel-Laszczak/usb-cdns2-Device-side-header-file-for-CDNS2-driver/20230216-195428 git checkout edb55f1c0a0ffe341211e08b1ebf162f48dd5b83 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=ia64 olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=ia64 SHELL=/bin/bash drivers/usb/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Link: https://lore.kernel.org/oe-kbuild-all/202302190436.AU6zwie0-lkp@xxxxxxxxx/ All warnings (new ones prefixed by >>): In file included from drivers/usb/gadget/udc/cdns2/cdns2-trace.h:29, from drivers/usb/gadget/udc/cdns2/cdns2-gadget.c:36: drivers/usb/gadget/udc/cdns2/cdns2-debug.h: In function 'cdns2_decode_trb': >> drivers/usb/gadget/udc/cdns2/cdns2-debug.h:165:13: warning: variable 'ret' set but not used [-Wunused-but-set-variable] 165 | int ret; | ^~~ drivers/usb/gadget/udc/cdns2/cdns2-gadget.c: In function 'cdns2_gadget_ep_enable': drivers/usb/gadget/udc/cdns2/cdns2-gadget.c:1408:49: warning: variable 'comp_desc' set but not used [-Wunused-but-set-variable] 1408 | const struct usb_ss_ep_comp_descriptor *comp_desc; | ^~~~~~~~~ -- In file included from drivers/usb/gadget/udc/cdns2/cdns2-trace.h:29, from drivers/usb/gadget/udc/cdns2/cdns2-ep0.c:13: drivers/usb/gadget/udc/cdns2/cdns2-debug.h: In function 'cdns2_decode_trb': >> drivers/usb/gadget/udc/cdns2/cdns2-debug.h:165:13: warning: variable 'ret' set but not used [-Wunused-but-set-variable] 165 | int ret; | ^~~ drivers/usb/gadget/udc/cdns2/cdns2-ep0.c: In function 'cdns2_ep0_stall': drivers/usb/gadget/udc/cdns2/cdns2-ep0.c:93:12: warning: variable 'reg' set but not used [-Wunused-but-set-variable] 93 | u8 reg; | ^~~ vim +/ret +165 drivers/usb/gadget/udc/cdns2/cdns2-debug.h 160 161 static inline const char *cdns2_decode_trb(char *str, size_t size, u32 flags, 162 u32 length, u32 buffer) 163 { 164 int type = TRB_FIELD_TO_TYPE(flags); > 165 int ret; 166 167 switch (type) { 168 case TRB_LINK: 169 ret = snprintf(str, size, 170 "LINK %08x type '%s' flags %c:%c:%c%c:%c", 171 buffer, cdns2_trb_type_string(type), 172 flags & TRB_CYCLE ? 'C' : 'c', 173 flags & TRB_TOGGLE ? 'T' : 't', 174 flags & TRB_CHAIN ? 'C' : 'c', 175 flags & TRB_CHAIN ? 'H' : 'h', 176 flags & TRB_IOC ? 'I' : 'i'); 177 break; 178 case TRB_NORMAL: 179 ret = snprintf(str, size, 180 "type: '%s', Buffer: %08x, length: %ld, burst len: %ld, " 181 "flags %c:%c:%c%c:%c", 182 cdns2_trb_type_string(type), 183 buffer, TRB_LEN(length), 184 TRB_FIELD_TO_BURST(length), 185 flags & TRB_CYCLE ? 'C' : 'c', 186 flags & TRB_ISP ? 'I' : 'i', 187 flags & TRB_CHAIN ? 'C' : 'c', 188 flags & TRB_CHAIN ? 'H' : 'h', 189 flags & TRB_IOC ? 'I' : 'i'); 190 break; 191 default: 192 ret = snprintf(str, size, "type '%s' -> raw %08x %08x %08x", 193 cdns2_trb_type_string(type), 194 buffer, length, flags); 195 } 196 197 return str; 198 } 199 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests
