Hi,
On 2023/02/16 20:35, Greg Kroah-Hartman wrote:
>> + if (bcd_version == 0x1) {
>> + pr_vdebug("bcdVersion is expected to be 0x100, but it was 0x%x. ",
>> + "Pass for compatibility, but fix your user space driver.\n",
>> + bcd_version);
>
> No one will see a debug message :(
>
> Make this a much louder warning please.
Okay, I will change it to pr_warn().
>> + pr_vdebug("bcdVersion is expected to be 0x100, but it was 0x%x. ",
And, the comma at the end of this is my mistake. I intended it to be just a
concatenation of strings. I will fix these in v2.
By the way, is there a problem with the "notify because the value 0x1 is wrong"
approach itself?
Thank you,
Yuta Hayama
