On Thu, Jan 19, 2023 at 03:37:52PM +0100, Christian Schaubschläger wrote: > Hi, > >> 8beb71759cc8fddd937cadf9ec482e524d4f0f1c is the first fixed commit > >> commit 8beb71759cc8fddd937cadf9ec482e524d4f0f1c > >> Author: Pierre Gondois <pierre.gondois@xxxxxxx> > >> Date: Wed May 18 11:08:58 2022 +0200 > >> > >> ACPI: bus: Set CPPC _OSC bits for all and when CPPC_LIB is supported > >> > >> [ Upstream commit 72f2ecb7ece7c1d89758d4929d98e95d95fe7199 ] > >> > >> The _OSC method allows the OS and firmware to communicate about > >> supported features/capabitlities. It also allows the OS to take > >> control of some features. > >> > >> In ACPI 6.4, s6.2.11.2 Platform-Wide OSPM Capabilities, the CPPC > >> (resp. v2) bit should be set by the OS if it 'supports controlling > >> processor performance via the interfaces described in the _CPC > >> object'. > >> > >> The OS supports CPPC and parses the _CPC object only if > >> CONFIG_ACPI_CPPC_LIB is set. Replace the x86 specific > >> boot_cpu_has(X86_FEATURE_HWP) dynamic check with an arch > >> generic CONFIG_ACPI_CPPC_LIB build-time check. > >> > >> Note: > >> CONFIG_X86_INTEL_PSTATE selects CONFIG_ACPI_CPPC_LIB. > >> > >> Signed-off-by: Pierre Gondois <pierre.gondois@xxxxxxx> > >> Reviewed-by: Sudeep Holla <sudeep.holla@xxxxxxx> > >> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx> > >> Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx> > >> > >> drivers/acpi/bus.c | 16 ++++++++-------- > >> 1 file changed, 8 insertions(+), 8 deletions(-) > >> > >> I've no idea why this solves the issue on the Lenovo, and obviously it doesn't solve it on the HP, but maybe this rings a bell somewhere? (Note: in my woking kernel config (on the Lenovo) I have neither CONFIG_X86_INTEL_PSTATE nor CONFIG_ACPI_CPPC_LIB set...) > > Can you check if with this commit reverted does Thunderbolt use software > > or firmware connection manager? (You can see this in the logs when > > thunderbolt.dyndbg=+p is in the command line). > > > You're right! With this commit reverted it uses the software connection manager, with the commit applied it uses the firmware connection manager. Hmm, so reverting this commit enables software connection manager and makes the Lenovo system work? Are you sure? that's completely opposite how the HP system behaves ;-)
